-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS): introduce RCTUIConfiguratorProtocol #47139
Open
okwasniewski
wants to merge
1
commit into
facebook:main
Choose a base branch
from
okwasniewski:feat/RCTUIConfiguratorProtocol
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(iOS): introduce RCTUIConfiguratorProtocol #47139
okwasniewski
wants to merge
1
commit into
facebook:main
from
okwasniewski:feat/RCTUIConfiguratorProtocol
+59
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Callstack
Partner: Callstack
Partner
labels
Oct 21, 2024
Error ReferenceError
Dangerfile
|
facebook-github-bot
added
the
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Oct 21, 2024
okwasniewski
commented
Oct 21, 2024
/** | ||
* The default `RCTColorSpace` for the app. It defaults to `RCTColorSpaceSRGB`. | ||
*/ | ||
- (RCTColorSpace)defaultColorSpace; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this from @property
, It was read-only anyways so I don't think it needs to be a property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Callstack
Partner: Callstack
Partner
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces
RCTUIConfiguratorProtocol
for better separation of concerns inside of RCTAppDelegate.It's also a prerequisite for #46298
Discussed with @cipolleschi
Changelog:
[IOS] [ADDED] - introduce RCTUIConfiguratorProtocol
Test Plan: